[5.3] Fix code logic in admin controllers #45037
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 0fbf20c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45037. |
|
@joomdonation You should restore @QuyTon 's test result in the issue tracker because it got lost with the branch update. You can use the "Alter test" button for that. |
|
Thanks @richard67. I had to don that to trigger CI re-run. I now altered test result from @QuyTon |
|
I have tested this item ✅ successfully on c5277db This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45037. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45037. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
In some of our controller classes, we have this line of code
$recordId = (int) isset($data[$key]) ? $data[$key] : 0;. It is clearly we want to have int casting applied to $data[$key]. However, with the current code, int casting is actually being applied to isset($data[$key]) and it is not right. This PR fixes that wrong logic.Testing Instructions
The change is the same for all controllers, so we will just need to test one
Actual result BEFORE applying this Pull Request
Works, but int casting is not applied to $data[$key] as expected
Expected result AFTER applying this Pull Request
Works, and int casting is applied properly to $data[$key] as expected
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed