Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Do not use the deprecated get functions in Joomla action log plugin #45033

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from
Open

[5.3] Do not use the deprecated get functions in Joomla action log plugin #45033

wants to merge 3 commits into from
+4 −4

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Feb 28, 2025

Summary of Changes

The get function is deprecated in the CMSObject class and therefore the action log Joomla plugin should treat the items as a stdClass object in the events.

This was discovered while doing #44945.

Testing Instructions

  • Upload a file
  • Upload the same file again and replace it
  • Create a folder
  • Delete the new folder
  • Delete the new file
  • Check if a action log entry is made for the different actions

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

@exlemor
Copy link

exlemor commented Feb 28, 2025

I have tested this item ✅ successfully on d893286

I have tested this successfully.

Just want to make sure of 1 thing, the log shows:

User exlemor deleted the media Media 7 minutes ago. 2025-03-01 00:23:50 Emmanuel Lemor 88
User exlemor added new media dragonfly-revisited-2.jpg Media 8 minutes ago. 2025-03-01 00:22:54 Emmanuel Lemor 87
User exlemor added new media PBF-Receipt.pdf Media 8 minutes ago. 2025-03-01 00:22:51 Emmanuel Lemor 86
User exlemor added new media dragonfly-revisited-2.jpg Media 9 minutes ago. 2025-03-01 00:21:53 Emmanuel Lemor 85
User exlemor added new media PBF-Receipt.pdf Media 9 minutes ago. 2025-03-01 00:21:52 Emmanuel Lemor 84

but it does NOT show the Creation or Deletion of the Folder, so iIF that is normal, then great, if NOT, then the PR needs an update.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45033.

@laoneo
Copy link
Member Author

laoneo commented Mar 1, 2025

For media items is no entry in action log creates.

@Fedik
Copy link
Member

Fedik commented Mar 5, 2025

I have tested this item ✅ successfully on a0aa1d8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45033.

@Fedik
Copy link
Member

Fedik commented Mar 5, 2025

r2c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45033.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laoneo @exlemor @Fedik @joomla-cms-bot