-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Guided Tours: What's New #44871
base: 5.3-dev
Are you sure you want to change the base?
Conversation
initial version
initial version
updated file image
What is this new feature? |
Did I misunderstand #44588? |
#44161 have been reverted |
Yes - A better description would be simply
However it is a very minor bug fix, not sure it is significant enough to even be mentioned |
Ok, we will update the tour |
Thanks will discuss with the team |
Removed reverted PR44161 Updated description of PR44588
Updated to reflect the changes to the tour
Does the image need to be so big? W: 2396px | H: 1540px |
I have tested this item ✅ successfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
I have tested this item 🔴 unsuccessfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
@VaishnaviSidral Please describe what you expect und what is not working so developer know what you mean. |
I have tested this item ✅ successfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
I have tested this item ✅ successfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
please update all links to rel='noopener noreferrer' |
using empty paragraphs for spacing is a mis-use of a semantic element and should not be done. If you need extra space then use the existing css classes |
Updated rel=\"noopener\" to rel=\"noopener noreferrer\"
removed empty paragraph tag
@@ -0,0 +1,2 @@ | |||
COM_GUIDEDTOURS_TOUR_WHATSNEW_5_3_DESCRIPTION = "<h1 class=\"fw-medium\">Welcome to Joomla 5.3!</h1><div class=\"row align-items-center mb-4 pt-4 border-top border-1\"><div class=\"col-md-6 col-lg-7\"><h2 class=\"mb-3\">Guided Tours Updates</h2><p>Guided Tours now has its own API. <a href=\"https://manual.joomla.org/docs/next/web-services-api/\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla API Documentation</a></p><p>Stay tuned for other new enhancements coming soon!</p></div></div><div class=\"row align-items-center border-top border-1 pt-4\"><div class=\"col-md-6 col-lg-5 text-center text-md-start mb-3 mb-md-0\"><img class=\"img-fluid\" src=\"media/com_guidedtours/images/5_3/filesdirectory.jpg\" alt=\"The first step of the welcome tour, showing the new media files folder\" width=\"521\" height=\"304\"></div><div class=\"col-md-6 col-lg-7 mb-3\"><h2 class=\"mb-3\">Core Updates</h2><h3 class=\"mb-3\">Organize Files in their Own Location</h3><p>Now you can see and select your stored/uploaded documents directly from the Media Manager. Find more information in the <a href=\"https://magazine.joomla.org/all-issues/december-2024/document-uploads-on-your-joomla-website\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla Community Magazine</a>.</p><h3 class=\"mb-3\">View Scheduled Task History</h3><p>You now have the ability to view execution information directly in the backend without having to access log files. Look for the <strong>Execution History</strong> button located in the Scheduled Tasks page.</p><h3>Other Enhancements and Fixes</h3><ul class=\"mb-3\"><li>Template Override Plugin Comparison - adds compare functionality to plugin overrides</li><li>Tag Alias Lookup Fixed - now instead of showing the tag id number in the URL the tag name is shown</li></ul></div></div>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it fine that COM_GUIDEDTOURS_TOUR_WHATSNEW_5_3_DESCRIPTION is not shown in red colour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @fgsw, why would the description be in red color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3_steps.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3_steps.ini
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
…teps.ini Co-authored-by: Brian Teeman <brian@teeman.net>
…teps.ini Co-authored-by: Brian Teeman <brian@teeman.net>
Summary of Changes
This PR will:
Testing Instructions
Download the update package, not the full install as the tour is only available on updates!
It is possible to find the tour in the list of tours at the top of the Joomla dashboard and run it manually.
Make sure you see images when running the tour (on the first step only) and when editing the tour (System -> Manage -> Guided tours).
Actual result BEFORE applying this Pull Request
No tour highlighting new features for Joomla 5.3.
Expected result AFTER applying this Pull Request
The What’s New in Joomla 5.3! tour is available.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed