Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Guided Tours: What's New #44871

Open
wants to merge 21 commits into
base: 5.3-dev
Choose a base branch
from
Open

Conversation

sdwjoomla
Copy link
Contributor

@sdwjoomla sdwjoomla commented Feb 12, 2025

Summary of Changes

This PR will:

  • add a tour that highlights new features introduced in Joomla 5.3
  • removes the autostart tour of the prior release

Testing Instructions

Download the update package, not the full install as the tour is only available on updates!

It is possible to find the tour in the list of tours at the top of the Joomla dashboard and run it manually.
Make sure you see images when running the tour (on the first step only) and when editing the tour (System -> Manage -> Guided tours).

Actual result BEFORE applying this Pull Request

No tour highlighting new features for Joomla 5.3.

Expected result AFTER applying this Pull Request

The What’s New in Joomla 5.3! tour is available.

whatnew53

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Feb 12, 2025
@brianteeman
Copy link
Contributor

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

@sdwjoomla
Copy link
Contributor Author

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

@heelc29
Copy link
Contributor

heelc29 commented Feb 13, 2025

#44161 have been reverted

@brianteeman
Copy link
Contributor

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

Yes - A better description would be simply

Template Overrides - Adds compare functionality to plugin overrides

However it is a very minor bug fix, not sure it is significant enough to even be mentioned

@sdwjoomla
Copy link
Contributor Author

#44161 have been reverted

Ok, we will update the tour

@sdwjoomla
Copy link
Contributor Author

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

Yes - A better description would be simply

Template Overrides - Adds compare functionality to plugin overrides

However it is a very minor bug fix, not sure it is significant enough to even be mentioned

Thanks will discuss with the team

Removed reverted PR44161
Updated description of PR44588
Updated to reflect the changes to the tour
@brianteeman
Copy link
Contributor

Does the image need to be so big? W: 2396px | H: 1540px

@sdwjoomla sdwjoomla marked this pull request as ready for review February 20, 2025 22:09
@fgsw
Copy link

fgsw commented Feb 21, 2025

I have tested this item ✅ successfully on 2567e2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@VaishnaviSidral
Copy link

I have tested this item 🔴 unsuccessfully on 2567e2d

I have tested and not working as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@fgsw
Copy link

fgsw commented Feb 22, 2025

I have tested and not working as expected

@VaishnaviSidral Please describe what you expect und what is not working so developer know what you mean.

@inforaghavms
Copy link

I have tested this item ✅ successfully on 2567e2d

Its tested and working fine as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@inforaghavms
Copy link

I have tested this item ✅ successfully on 2567e2d

Test is working fine as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@brianteeman
Copy link
Contributor

please update all links to rel='noopener noreferrer'

@brianteeman
Copy link
Contributor

using empty paragraphs for spacing is a mis-use of a semantic element and should not be done. If you need extra space then use the existing css classes

sdwjoomla and others added 3 commits February 23, 2025 09:08
@@ -0,0 +1,2 @@
COM_GUIDEDTOURS_TOUR_WHATSNEW_5_3_DESCRIPTION = "<h1 class=\"fw-medium\">Welcome to Joomla 5.3!</h1><div class=\"row align-items-center mb-4 pt-4 border-top border-1\"><div class=\"col-md-6 col-lg-7\"><h2 class=\"mb-3\">Guided Tours Updates</h2><p>Guided Tours now has its own API. <a href=\"https://manual.joomla.org/docs/next/web-services-api/\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla API Documentation</a></p><p>Stay tuned for other new enhancements coming soon!</p></div></div><div class=\"row align-items-center border-top border-1 pt-4\"><div class=\"col-md-6 col-lg-5 text-center text-md-start mb-3 mb-md-0\"><img class=\"img-fluid\" src=\"media/com_guidedtours/images/5_3/filesdirectory.jpg\" alt=\"The first step of the welcome tour, showing the new media files folder\" width=\"521\" height=\"304\"></div><div class=\"col-md-6 col-lg-7 mb-3\"><h2 class=\"mb-3\">Core Updates</h2><h3 class=\"mb-3\">Organize Files in their Own Location</h3><p>Now you can see and select your stored/uploaded documents directly from the Media Manager. Find more information in the <a href=\"https://magazine.joomla.org/all-issues/december-2024/document-uploads-on-your-joomla-website\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla Community Magazine</a>.</p><h3 class=\"mb-3\">View Scheduled Task History</h3><p>You now have the ability to view execution information directly in the backend without having to access log files. Look for the <strong>Execution History</strong> button located in the Scheduled Tasks page.</p><h3>Other Enhancements and Fixes</h3><ul class=\"mb-3\"><li>Template Override Plugin Comparison - adds compare functionality to plugin overrides</li><li>Tag Alias Lookup Fixed - now instead of showing the tag id number in the URL the tag name is shown</li></ul></div></div>"
Copy link

@fgsw fgsw Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine that COM_GUIDEDTOURS_TOUR_WHATSNEW_5_3_DESCRIPTION is not shown in red colour?

Copy link
Contributor

@obuisard obuisard Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fgsw, why would the description be in red color?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Difference between other language constants like below and the mentioned one:

Untitled

obuisard and others added 4 commits March 4, 2025 09:24
…teps.ini

Co-authored-by: Brian Teeman <brian@teeman.net>
…teps.ini

Co-authored-by: Brian Teeman <brian@teeman.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants