Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] fine grain task notification mail #44604

Merged
merged 13 commits into from
Feb 28, 2025
Merged

[5.3] fine grain task notification mail #44604

merged 13 commits into from
Feb 28, 2025
+86 −32

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 11, 2024 •
edited
Loading

Pull Request for Issue #39311 .

must be tested after/with #44587

Summary of Changes

Fine grain the notification email of tasks

Testing Instructions

  • have a scheduled task.

  • Set the task notifications to on and choose usergroups (default is Super User)
    image

  • run the task

Actual result BEFORE applying this Pull Request

All users with receive system emails turned on receive notifications about tasks

Expected result AFTER applying this Pull Request

Only the users with receive system emails turned on and belonging to the group configured for notification will receive the mail

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

@alikon
task_notification_usergroups

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
9c34de4
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 11, 2024
alikon added 2 commits January 8, 2025 08:28
@alikon
Merge branch '5.3-dev' into task-notification-usergroups

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
daf9297
@alikon
Merge branch '5.3-dev' into task-notification-usergroups

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
776d549
@alikon alikon changed the title task_notification_usergroups [5.3] fine grain task notification mail Jan 9, 2025
@alikon
Merge branch '5.3-dev' into task-notification-usergroups

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
0d77e99
@alikon alikon marked this pull request as ready for review January 9, 2025 11:49
@alikon alikon mentioned this pull request Jan 9, 2025
Closed
@alikon
msg

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
e03dbb4
@Kostelano
Copy link
Contributor

I added a new user to the Registered group, enabled receiving system notifications by mail, added the Registered group in the task settings for successful execution.

Result: only the superadmin receives notifications by mail. The registered user's mail is silent.

alikon added 2 commits January 19, 2025 08:31
@alikon
Merge branch '5.3-dev' into task-notification-usergroups

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
b2675ca
@alikon
no special permission

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
2942570
@alikon
Copy link
Contributor Author

alikon commented Jan 19, 2025

@Kostelano fixed

@Kostelano
Copy link
Contributor

This is fixed, yes.

If the user is in two, three, etc. groups and these groups are added to the new task parameters, then notifications come 2, 3, etc. times, the same ones. I'm not sure if this is intended.

Probably, the problem does not look serious considering that usually the recipient of the "task completion report" will be the superadmin or several of the most important users (who will be in 1 group), but it is still worth mentioning.

If this is ok, let me know, I will send a successful test.

@alikon
1-mail-x-user

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
515c8c3
@alikon
Copy link
Contributor Author

alikon commented Jan 19, 2025

good point
now 1 mail per user regardless on how much user groups he/she is in

@alikon
cs

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
9ffe02a
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 9ffe02a

Now it works as stated, no deviations were noticed

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

@alikon
doc-block

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
2c7df52
@alikon @QuyTon
Update plugins/system/tasknotification/src/Extension/TaskNotification…

Verified

This commit was signed with the committer’s verified signature.
dgrammatiko Dimitris Grammatikogiannis
GPG key ID: 2F95D3DBC890DF63
Verified
Learn about vigilant mode
Loading
Loading status checks…
2a3aa18 
….php

Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
@MacJoom MacJoom added the PBF Pizza, Bugs and Fun label Feb 18, 2025
@ceus1984
Copy link

I have tested this item ✅ successfully on 2a3aa18

Added a task and tested it with two users from different usergroups. Worked ok

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

@crommie
Copy link

crommie commented Feb 22, 2025

I have tested this item ✅ successfully on 2a3aa18

Tested on 5.3-dev on the PBF server using patch tester.

Works as described.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

@alikon
Copy link
Contributor Author

alikon commented Feb 22, 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

@alikon alikon removed the PBF Pizza, Bugs and Fun label Feb 22, 2025
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@alikon alikon added the PBF Pizza, Bugs and Fun label Feb 22, 2025
@webfeuerflo
Copy link

Tested successfully

@Sabine-2023
Copy link

I have tested this item ✅ successfully on 2a3aa18

Works as expected. Mails were sent only to the assigned user group after adding patch.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

@exlemor
Copy link

exlemor commented Feb 22, 2025 •
edited
Loading

During PBF 2025, Martina and I both tested it on Lucushost PBF server #22 and #44 and it failed - we send using PHP Mail and SendMail... without luck

@crommie
Copy link

crommie commented Feb 22, 2025

Notifications have to be switched on in the task settings. Maybe you forgot? It's switched off by default for successful tasks.

@alikon
Copy link
Contributor Author

alikon commented Feb 22, 2025

@exlemor did you switch on notification in case of task success ?
or are you testing a different scenario ?

@rdeutz rdeutz added the bug label Feb 27, 2025
@richard67
Merge branch '5.3-dev' into task-notification-usergroups

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
8b39d71
@richard67
Copy link
Member

richard67 commented Feb 28, 2025 •
edited
Loading

I've allowed myself to solve the merge conflict which was caused by PR #44967 ,

@rdeutz
Merge branch '5.3-dev' into task-notification-usergroups

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
5bcbb87
@rdeutz rdeutz merged commit eb65310 into joomla:5.3-dev Feb 28, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 28, 2025
@alikon alikon deleted the task-notification-usergroups branch February 28, 2025 19:04
@jgerman-bot jgerman-bot mentioned this pull request Mar 1, 2025
Closed
@richard67 richard67 added this to the Joomla! 5.3.0 milestone Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuyTon QuyTon

Assignees
No one assigned
Labels
bug Language Change This is for Translators PBF Pizza, Bugs and Fun PR-5.3-dev
Projects
None yet
Milestone
Joomla! 5.3.0
Development

Successfully merging this pull request may close these issues.

None yet