[6.0] CategoryNode/Changelog: Remove legacy error handling trait #43777
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hackwar
added
the
b/c break
|
This needs to be documented in the manual/Release Notes. |
|
Hi @Hackwar, please can you add the PR for the manual? |
|
Done. |
|
I have tested this item ✅ successfully on f94aec5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43777. |
|
I have tested this item ✅ successfully on f94aec5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43777. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The LegacyErrorHandlingTrait is part of our legacy error handling, which has been deprecated since Joomla 3.1 already. In an effort to remove this finally from the core, this PR removes the trait from the CategoryNode and Changelog class, since they are NOT used in those classes anyway. This is a b/c break and thus has to go into 6.0.
Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Remove LegacyErrorHandlingTrait from CategoryNode & Changelog Manual#386
No documentation changes for manual.joomla.org needed