[5.3] CMSPlugin: Deprecate use of DispatcherAware and LanguageAware #43430
+147
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
|
This pull request has been automatically rebased to 5.3-dev. |
HLeithner
changed the title
Conflicts: plugins/editors/none/src/Extension/None.php
|
I have tested this item ✅ successfully on 32f8a00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43430. |
|
I have tested this item ✅ successfully on 32f8a00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43430. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43430. |
Conflicts: plugins/content/finder/src/Extension/Finder.php
This was referenced Mar 1, 2025
|
@rdeutz is something wrong with this pr or what's the reason that the corresponding manual pr has not been merged? Please revert the pr if it's wrong or merge the manual pr. thanks |
I made it later, and forgot to ping @rdeutz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Deprecate use of DispatcherAware and LanguageAware within CMSPlugin class.
Plugin should use DispatcherAware it on its own.
And LanguageAware is a leftover from some changes in past, and does not used anywhere (I did not found).
Testing Instructions
Code review.
Navigate around the site.
Edit site content.
Use finder indexer.
All should work as before.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Linked: