0m 48s
Jan 14, 2025, 12:17 AM

utilities

Updating phpstan to 2.0 (#47) * Updating phpstan to 2.0 * Adding PHP 8.3/8.4 everywhere

Hackwar
executed scheduled task
nightly-build-3-x

Pipeline stages

6 stages

Console Logs

1+ ./vendor/bin/phpstan 1s
2Note: Using configuration file /drone/src/phpstan.neon. 2s
3 0/3 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░] 0% 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 6s
4 6s
5 ------ ---------------------------------------------------------------------- 6s
6 Line ArrayHelper.php 6s
7 ------ ---------------------------------------------------------------------- 6s
8 42 Call to function is_array() with array will always evaluate to true. 6s
9 🪪 function.alreadyNarrowedType 6s
10 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
11 check by setting treatPhpDocTypesAsCertain: false in your 6s
12 phpstan.neon. 6s
13 46 Unreachable statement - code above always terminates. 6s
14 🪪 deadCode.unreachable 6s
15 128 Call to function is_array() with *NEVER* will always evaluate to 6s
16 true. 6s
17 🪪 function.alreadyNarrowedType 6s
18 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
19 check by setting treatPhpDocTypesAsCertain: false in your 6s
20 phpstan.neon. 6s
21 128 Call to function is_object() with object will always evaluate to 6s
22 true. 6s
23 🪪 function.alreadyNarrowedType 6s
24 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
25 check by setting treatPhpDocTypesAsCertain: false in your 6s
26 phpstan.neon. 6s
27 128 Result of || is always true. 6s
28 🪪 booleanOr.alwaysTrue 6s
29 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
30 check by setting treatPhpDocTypesAsCertain: false in your 6s
31 phpstan.neon. 6s
32 132 Unreachable statement - code above always terminates. 6s
33 🪪 deadCode.unreachable 6s
34 174 Method Joomla\Utilities\ArrayHelper::arrayFromObject() should return 6s
35 array but returns mixed. 6s
36 🪪 return.type 6s
37 💡 Type array<mixed, mixed>|object has already been eliminated from 6s
38 mixed. 6s
39 210 Variable $colName in isset() always exists and is not nullable. 6s
40 🪪 isset.variable 6s
41 214 Variable $colName in isset() always exists and is not nullable. 6s
42 🪪 isset.variable 6s
43 277 Strict comparison using === between string and null will always 6s
44 evaluate to false. 6s
45 🪪 identical.alwaysFalse 6s
46 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
47 check by setting treatPhpDocTypesAsCertain: false in your 6s
48 phpstan.neon. 6s
49 314 Instanceof between ArrayAccess and ArrayAccess will always evaluate 6s
50 to true. 6s
51 🪪 instanceof.alwaysTrue 6s
52 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
53 check by setting treatPhpDocTypesAsCertain: false in your 6s
54 phpstan.neon. 6s
55 314 Result of && is always false. 6s
56 🪪 booleanAnd.alwaysFalse 6s
57 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
58 check by setting treatPhpDocTypesAsCertain: false in your 6s
59 phpstan.neon. 6s
60 443 Call to function is_array() with array will always evaluate to true. 6s
61 🪪 function.alreadyNarrowedType 6s
62 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
63 check by setting treatPhpDocTypesAsCertain: false in your 6s
64 phpstan.neon. 6s
65 561 Variable $caseSensitive might not be defined. 6s
66 🪪 variable.undefined 6s
67 562 Variable $locale might not be defined. 6s
68 🪪 variable.undefined 6s
69 564 Variable $locale might not be defined. 6s
70 🪪 variable.undefined 6s
71 568 Variable $direction might not be defined. 6s
72 🪪 variable.undefined 6s
73 572 Variable $direction might not be defined. 6s
74 🪪 variable.undefined 6s
75 675 Call to function is_array() with array will always evaluate to true. 6s
76 🪪 function.alreadyNarrowedType 6s
77 💡 Because the type is coming from a PHPDoc, you can turn off this 6s
78 check by setting treatPhpDocTypesAsCertain: false in your 6s
79 phpstan.neon. 6s
80 ------ ---------------------------------------------------------------------- 6s
81 6s
82 ------ ------------------------------------------------------------------ 6s
83 Line IpHelper.php 6s
84 ------ ------------------------------------------------------------------ 6s
85 232 Parameter #3 $length of function substr expects int|null, 6s
86 float|string given. 6s
87 🪪 argument.type 6s
88 233 Parameter #3 $length of function substr expects int|null, 6s
89 float|string given. 6s
90 🪪 argument.type 6s
91 295 Variable $netmask might not be defined. 6s
92 🪪 variable.undefined 6s
93 307 Ternary operator condition is always false. 6s
94 🪪 ternary.alwaysFalse 6s
95 311 Parameter #3 $length of function substr expects int|null, float 6s
96 given. 6s
97 🪪 argument.type 6s
98 312 Parameter #3 $length of function substr expects int|null, float 6s
99 given. 6s
100 🪪 argument.type 6s
101 419 Variable $_SERVER in isset() always exists and is not nullable. 6s
102 🪪 isset.variable 6s
103 509 Parameter #3 $length of function substr expects int|null, string 6s
104 given. 6s
105 🪪 argument.type 6s
106 510 Parameter #3 $length of function substr expects int|null, string 6s
107 given. 6s
108 🪪 argument.type 6s
109 ------ ------------------------------------------------------------------ 6s
110 6s
111 [ERROR] Found 28 errors 6s
112 6s
Exit Code 1